-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated terminal poor performance and freezing #53782
Comments
(Experimental duplicate detection) |
@phil-harmoniq when you're seeing these problems can you run You can also try updating your graphics card drivers or adding this setting:
|
Here is the result of
Here is the output of
|
I've been experiencing this too since the last update. Changing the render mode makes no difference, From what I can tell, it gets progressively worse over time. Every 5 or 10 minutes I need to recreate the terminal and it's back to normal. Here's my --status:
|
@phil-harmoniq did you try the DOM rendererType? @Southclaws did you relaunch the terminal after setting |
Yeah I've tried both render types and done restarts after changing. |
@Southclaws does closing all windows and running |
I haven't updated my drivers in a while, so I'll give that a shot. |
I will try using the DOM renderer once I get back home. However, I do know that I am using the latest graphics drivers available from Nvidia. |
The integrated terminal is still very sluggish when using the DOM renderer, but it seems to not completely freeze VS Code at least. |
I just tested this while booted into Ubuntu 18.04, and it is also having this issue. I don't think this is isolated to Windows; however, my Macbook Pro seems to be immune. In macOS VS Code will still show the popup "The standard renderer appears to be slow" but I don't experience any slow down. Edit: I also just tried this on my Surface Pro which has no dedicated GPU, and it also experiences this issue. |
@phil-harmoniq that popup should only appear if the first 10 frames render time averages to over 50ms. You may not perceive this but it's very slow and something has gone wrong, it's meant to be around 1-3ms. Thanks for the feedback |
I'm having this problem as well. The Ubuntu 18.04 integrated terminal freezes, memory usage skyrockets (> 8 GB), and Windows 10 eventually realizes VS Code is unresponsive and prompts me to reopen or close it. I updated to the latest Quadro drivers from Nvidia, but the lockups are still happening. Here's the
|
@jpayne |
That seems to have stopped it from crashing @Tyriar, but rendering is now quite slow. I've never had to do this with previous version of VS Code FWIW. |
I have been experiencing this since upgrading to 1.24 and still having it at 1.25:1 (upgraded on July 11, 2018). None of the previously recommended fixes solved this problem. code --status
|
Same here (note the high
|
tried adding "terminal.integrated.rendererType": "dom" |
I am also running into the same or similar problem with the terminal. And I can reproduce a freeze on my system 100%. For repo:
After these steps all of vscode will freeze, eventually ending with a "This window is no longer responding." error. While it is frozen, this is the output from code --status from another terminal:
I am running the latest drivers on my system. Both running Happy to act as a guinea pig or provide more details if it helps get this resolved :) |
@archcomet did you get the slow renderer notification before setting |
@Tyriar I do not recall seeing any notifications. |
I just got a Window not responding running a git log command which is interactive.
|
I'm also having this issue on a new Dell XPS laptop I got yesterday. I wanted to share that downgrading my laptop's resolution from 4K to 1080p solves the slugginesh / crashing completely, but it looks less sharp, so I wish there was another solution. I tried changing the renderer type to |
I'm also having crashes on an XPS 13 with 4k display. I haven't tried any steps to diagnose/fix it yet, just been using separate powershell window instead of the integrated terminal. |
@angel-urena might be on to something. I am also on a new Dell XPS with a 4K display. Can confirm that lowering the resolution also prevents the crashing. |
Good observation, all of my screens are 4K-ish (4K monitor, retina MacBook Pro, Surface Pro 4) |
Can confirm. 4K monitor here and VS code crashes if I increase the size of the terminal pane. However, I did get an intelligent pop up from VS Code at one point linking me here: https://code.visualstudio.com/docs/editor/integrated-terminal#_changing-how-the-terminal-is-rendered It said this: The standard renderer for the integrated terminal appears to be slow on your computer. Would you like to switch to the alternative DOM-based renderer which may improve performance? Read more about terminal settings. EDIT: This does appear to fix the issue. |
Same here (4K display). EDIT: Switching to the alternative DOM-based renderer does improve the performance, but it still lags. I found that the performance decreases with an increasing height of the terminal panel. |
Yep, 4K here too.
On Tue, Aug 7, 2018, at 4:35 AM, Claas Augner wrote:
Same here (4K display).
— You are receiving this because you were mentioned. Reply to this
email directly, view it on GitHub[1], or mute the thread[2].
|
Well it's definitely looking like it's a 4K monitor problem, I'll see if I can get my hands on one |
Also been having this problem for a while now. In addition to the 4k monitor (Surface Book here) as the slowdown appears to get worse over time, the problem also seems to be exacerbated when progress spinners/bars are being displayed (e.g., npm install, docker push). I presume this is due to the clearing and redraws to get the animated effect in the terminal? Not sure if that helps in debugging but perhaps makes it easier to repro. |
Confirming this happens on a 4K HP Spectre 13. Definitely an annoying bug. NPM commands easily seem to reproduce it on my machine. |
FWIW slight variation - I have 3x 2560x1600 monitors in a row and also get the lagging. Code is maximized to a single window, can type faster then the terminal can echo (and I don't type that fast :P ). Ubuntu 18.04:
I have also noticed that when the terminal is selected in the bottom panel, changing the height of the bottom panel is laggy/choppy. If I switch to a different item in the bottom panel, such as "Problems" and change the height I don't get that same lag. I get the same behavior with the "bottom panel" being changed to be docked to the right. I can also confirm the the lag increases along with increasing the size of the terminal. |
Another confirmation of the 4k problem here (Ubuntu 18.04 on a brand new Dell XPS 9730) |
@Tyriar i am experiencing this in 2k(2560x1440) resolution as well; Using dom based terminal AND --disable-gpu helps |
I am seeing this on my MacBook Pro with a 4k monitor attached, so not limited to windows. |
Hi, since 1.26 I experience the same issue. Setting
I found E.g. the version info of VSCode 1.26.1 shows Electron in version 2.0.5 already:
|
Hi, I just tried to set Here's the result of
VS Code is unable to see it, but I have hardware acceleration (I know it, and I checked it with |
Another workaround that may work: |
For what it's worth I also experience sudden performance drop after a while when using integrated terminal on my Dell XPS 15 9560 w/ 4K display. Most noticed when using Powershell integrated terminal from the extention (probably because it's the one I use the most on daily basis). I've noticed that when having just vscode and chrome open, when it suddenly starts lagging Chrome lags as well with the scrolling. Closing both apps and reopening Chrome make scroll smooth again. |
Thanks @Tyriar, this works for me. Changing |
I'm going to close this issue in favor of the following 2 issues as they're more targeted:
|
Steps to Reproduce:
Does this issue occur when all extensions are disabled?: Yes
The integrated terminal is freezing constantly and sometimes causing VS Code to take over 8GB of RAM and causing my entire system to become sluggish. I've seen this issue reported and claiming that version 1.24 would fix this but it hasn't and now those threads have all been locked. #36913 #47196 #46954
On the insiders version it seems to at least only freeze the terminal window itself, but this has basically made the terminal unusable for me. 🙁
I'd also like to note that keeping the terminal small minimizes the performance impact but is still noticeably sluggish
The text was updated successfully, but these errors were encountered: