Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find match was not cleared after dismiss #59373

Closed
rebornix opened this issue Sep 25, 2018 · 2 comments
Closed

Find match was not cleared after dismiss #59373

rebornix opened this issue Sep 25, 2018 · 2 comments
Assignees
@Tyriar
Labels
*as-designed Described behavior is as designed

Comments

@rebornix
Copy link
Member

#59267.

  • Open vscode repo folder
  • ls
  • Find .editorConfig, press enter, .editorConfig was selected
  • Esc to close the find widget, find match decoration is not cleared
@vscodebot vscodebot bot added editor editor-find Editor find operations labels Sep 25, 2018
@alexdima alexdima removed editor editor-find Editor find operations labels Oct 8, 2018
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Oct 11, 2018
@vscodebot
Copy link

vscodebot bot commented Oct 11, 2018

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 11, 2018
@Tyriar
Copy link
Member

Tyriar commented Oct 11, 2018

Behaves the same as the editor atm, also this is something that would probably be changed in xtermjs/xterm.js#1653

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*as-designed Described behavior is as designed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rebornix @Tyriar @alexdima