Find in Terminal: Only scroll when necessary

[chrmarti]

Issue Type: Bug

Testing #59267

Currently the current match is scrolled to the top. The scrolling behavior should align with the one in the editor.

VS Code version: Code - Insiders 1.28.0-insider (5ba5f14, 2018-09-26T07:28:12.336Z)
OS version: Linux x64 4.15.0-33-generic

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (2 x 2194)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: disabled_off native_gpu_memory_buffers: disabled_software rasterization: disabled_software video_decode: unavailable_software video_encode: unavailable_software webgl: enabled webgl2: enabled
Load (avg)	0, 0, 0
Memory (System)	5.77GB (0.68GB free)
Process Argv	--user-data-dir=tmp/usr --extensions-dir=tmp/ext
Screen Reader	no
VM	100%

Extensions: none

[chrmarti]

This also doesn't work well with how the find widget is positioned because that covers matches at the end of lines.

[alexr00]

Duplicate of #50623

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!