Terminal link underlines on lines that start with \t are offset

[ejizba]

Issue Type: Bug

I've started noticing the line under the hyperlink looks weird on insiders:

This is what it looks like on non-insiders:

I think I narrowed it down to when there's a tab and a link. Here's the simplest task I could create that repros this:

{
  "version": "2.0.0",
  "tasks": [
    {
      "label": "test",
      "type": "shell",
      "command": "echo '	http://localhost:7071/api/HttpTrigger'",
      "problemMatcher": []
    }
  ]
}

VS Code version: Code - Insiders 1.31.0-insider (b4fc71b, 2019-01-15T06:12:40.322Z)
OS version: Darwin x64 18.2.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	16.00GB (0.57GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (6)

Extension	Author (truncated)	Version
tslint	eg2	1.0.42
python	ms-	2018.12.1
azure-account	ms-	0.8.0
csharp	ms-	1.17.1
java	red	0.36.0
vscode-java-debug	vsc	0.16.0

[Tyriar]

Upstream PR: xtermjs/xterm.js#1887, too late to pull into 1.31

[ejizba]

Fixed for me on latest insiders - thanks!