Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with extension "Commitizen" and him adapter "cz-emoji" #81444

Closed
rushelex opened this issue Sep 25, 2019 · 1 comment
Closed

Bug with extension "Commitizen" and him adapter "cz-emoji" #81444

rushelex opened this issue Sep 25, 2019 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@rushelex
Copy link

  • VSCode Version: 1.38.1
    Electron: 4.2.10
    Chrome: 69.0.3497.128
    Node.js: 10.11.0
    V8: 6.9.427.31-electron.0
  • OS Version: Windows_NT x64 10.0.18362

Steps to Reproduce:

  1. Install package "Commitizen" via npm:
    npm install -g commitizen
  2. Install package "cz-emoji" via npm:
    npm install -g cz-emoji
    npm install --save-dev cz-emoji
  3. Set as default adapter for your projects in package.json:
"config": {
     "commitizen": {
       "path": "./node_modules/cz-emoji"
     },
   }
  1. Write commit via git cz
  2. Here in the built-in terminal there is a bug with emoticons

More details:

In the built-in terminal there is a bug with emoticons.
65462225-c1297800-de6e-11e9-8929-8b14505bfd4f
The image shows that in front of the emoticons there is a question mark, which breaks the display of emoticons in the terminal. By the link Google Drive you can see the whole essence of the problem. The smiley does not change while moving through the list.

The error is also described in the issue ngryman/cz-emoji#26 (comment), but, I think, the error is not in the extension, but in the editor's terminal.

@Tyriar
Copy link
Member

Tyriar commented Sep 26, 2019

/duplicate #66125

@Tyriar Tyriar closed this as completed Sep 26, 2019
@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 26, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants