Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Ctrl+Click for node object containing url adds ', to urls which contain ? #94572

Closed
akulmehta opened this issue Apr 6, 2020 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@akulmehta
Copy link

akulmehta commented Apr 6, 2020

  • VSCode Version: 1.43.2
  • OS Version: Windows 10 (10.0.17763)
  • Node.js: 12.8.1

Steps to Reproduce:

  1. Console.log with node an object which contains a url with ? using Windows PowerShell
    for e.g.
    console.log( { linkText: 'DuckDuck Go: my query', href: 'https://duckduckgo.com/?q=myquery&t=h_&ia=web', parentCell: 3 }, { linkText: 'DuckDuck Go', href: 'https://duckduckgo.com/', parentCell: 3 } );
  2. The console will show the href, over which if the mouse hovers it will allow you to ctrl+click.
  3. For the link 'https://duckduckgo.com/?q=myquery&t=h_&ia=web', the url copied and opened in the browser will also contain ',.
    While in the case of duckduckgo this is not a problem, for other urls it can produce 404 errors.
  4. This seems to happen only with urls containing ? in the url.

Does this issue occur when all extensions are disabled?: Yes/No

@IllusionMH
Copy link
Contributor

Looks like duplicate of #21125 however pick more symbols than usual.

@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants
@IllusionMH @Tyriar @akulmehta and others