Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce gemm_softmax_gemm to codegen #1542

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Introduce gemm_softmax_gemm to codegen #1542

wants to merge 9 commits into from
+1,034 −54

Conversation

mirza-halilcevic
Copy link
Collaborator

@mirza-halilcevic mirza-halilcevic commented Oct 2, 2024 •
edited
Loading

@mirza-halilcevic mirza-halilcevic marked this pull request as ready for review October 2, 2024 12:30
@carlushuang
Copy link
Contributor

@mirza-halilcevic looks like recently there are many migraphx related request to design codegen utilty under CK. I think this has some overlap of our ck-tile roadmap item, and I think introducing ck-host library is also a duplication of what we plan to do. This PR introduce some extra component into CK build system, I think we need think if this is aligned with our future development, as well as code manitainance

cc @junliume @illsilin

pfultz2
pfultz2 reviewed Oct 16, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@mirza-halilcevic mirza-halilcevic changed the title Introduce ck_host library and gemm_softmax_gemm Introduce gemm_softmax_gemm to codegen Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfultz2 pfultz2 pfultz2 left review comments

@junliume junliume Awaiting requested review from junliume junliume is a code owner

@illsilin illsilin Awaiting requested review from illsilin illsilin is a code owner

@carlushuang carlushuang Awaiting requested review from carlushuang carlushuang is a code owner

@aosewski aosewski Awaiting requested review from aosewski aosewski is a code owner

@poyenc poyenc Awaiting requested review from poyenc poyenc is a code owner

@geyyer geyyer Awaiting requested review from geyyer geyyer is a code owner

@bartekxk bartekxk Awaiting requested review from bartekxk bartekxk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Composable Kernel Integration
3 participants
@mirza-halilcevic @carlushuang @pfultz2