Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Fixed integer scaling #35

Open
parkerlreed opened this issue Apr 1, 2022 · 5 comments
Open

[Feature request] Fixed integer scaling #35

parkerlreed opened this issue Apr 1, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@parkerlreed
Copy link

Using on the tablet (Tab S7+ on Android 12) it doesn't lock to any integer scale, so trying to zoom in and out to get it to look good is very tricky. Full screen tries but is still off by a little.

@parkerlreed
Copy link
Author

Video showing the scaling (and an issue where in full screen, the pointer location is very offset)

20220401_172653.mp4

@mihaip
Copy link
Owner

mihaip commented Apr 5, 2022

I recently made some fixes for scaling (9027c56) and touch/mouse event handling (3788b5d), is it any better for you? I don't have access to an Android tablet, but FWIW I'm not seeing these issues on an iPad.

@parkerlreed
Copy link
Author

Looking at the system 7 site, it still seems to be wonky.

Along with the full screen input still being very offset.

20220406_115946

@parkerlreed
Copy link
Author

I set a breakpoint for isFullscreen and I get these as the variables

Could the uneven scale be what's throwing this off?

heightScale: 1.5583333333333333
isFullScreen: true
widthScale: 1.8675

image

@mihaip
Copy link
Owner

mihaip commented Apr 6, 2022

We choose whichever is smaller, but we don't round (prioritizing filling up the screen).

@mihaip mihaip added the enhancement New feature or request label Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants