Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip showing which sites support remote disk images #360

Open
Kwpolska opened this issue Jan 9, 2025 · 1 comment
Open

Tooltip showing which sites support remote disk images #360

Kwpolska opened this issue Jan 9, 2025 · 1 comment
Labels
Site Enhancements to the site itself

Comments

@Kwpolska
Copy link

Kwpolska commented Jan 9, 2025

The page for setting up a custom configuration requires disk images from "a supported site" and links to GitHub code search. Code search requires signing into a GitHub user account. It may be easier to link to the precise place in the codebase, like https://github.com/mihaip/infinite-mac/blob/fa69baec2f2ddb50d6cf7c271aeef823aecb738e/workers-site/cd-rom.ts#L38C5-L46C7 .

@mihaip
Copy link
Owner

mihaip commented Jan 11, 2025

It was somewhat intentional to use a code search (so that it would point to live values) as opposed to a URL with a commit hash embedded in it.

But all of that is a hack, what I should really do is pull the list of allowed sites into a shared constant and used it in both the worker and the UI.

@mihaip mihaip changed the title Consider not linking to GitHub code search Tooltip showing which sites support remote disk images Jan 11, 2025
@mihaip mihaip added the Site Enhancements to the site itself label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Enhancements to the site itself
Projects
None yet
Development

No branches or pull requests

2 participants