Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain devices are failing payload CRC checks #9

Closed
mill1000 opened this issue Jul 26, 2023 · 0 comments · Fixed by #10
Closed

Certain devices are failing payload CRC checks #9

mill1000 opened this issue Jul 26, 2023 · 0 comments · Fixed by #10
Assignees
@mill1000

Comments

@mill1000
Copy link
Owner

It appears some devices don't protect the payload with a CRC8 but instead another checksum. Older version of msmart (< 0.2.4) never bothered to check the CRC (or frame checksum) and thus never had a problem.

This has been reported in multiple places:
mac-zhou/issues/103
mac-zhou/issues/104
mill1000/midea-ac-py/issues/11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mill1000 mill1000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept valid checksum or CRC for device responses mill1000/midea-msmart
1 participant
@mill1000