Skip to content
This repository has been archived by the owner on Jul 21, 2022. It is now read-only.

Some newer components aren't showing on the heroku app #60

Open
johnnolan opened this issue May 24, 2021 · 4 comments
Open

Some newer components aren't showing on the heroku app #60

johnnolan opened this issue May 24, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@johnnolan
Copy link
Contributor

johnnolan commented May 24, 2021

Prerequisites

  • [x ] Put an X between the brackets on this line if you have done all of the following:
    • Reproduced the problem
    • Followed all applicable steps in the debugging guide
    • Checked the FAQs on the message board for common solutions
    • Checked that your issue doesn't exist: https://github.com/ministryofjustice/moj-design-system/issues
    • Checked that there is not already a package that provides the described functionality

Description

See here for example: https://moj-design-system.herokuapp.com/components/ticket-panel also missing is the Cookie Banner and probably others.

Requires looking at missing components and adding the relevant documentation for each in https://github.com/ministryofjustice/moj-design-system/tree/main/app/views/components

Steps to Reproduce

  1. Go to https://moj-design-system.herokuapp.com/components
  2. Look at side navigation
  3. Some components are not showing and 404 on direct links from Readmes

Expected behaviour: All available components to show

Actual behaviour: No visibility of newer components

Reproduces how often: 100%

Versions

You can get this information from the CHANGELOG. Also, please include details of the browser and OS version you're running.

Additional Information

Also relates to #43

@johnnolan johnnolan added the bug Something isn't working label May 24, 2021
@johnnolan
Copy link
Contributor Author

Identified by @rwk-moj

@gregtyler
Copy link
Contributor

This isn't a Heroku issue, it's just that no-one's written any documentation for them yet.

I don't think there's much point acknowledging the cookie banner component, since the GOV.UK one supersedes it.

Also worth noting that I'm currently experimenting with moving all the documentation into a static-site generator in the moj-frontend repository, so we can keep the docs and the code in one place. Hopefully that'll make it easier to write documentation as we go.

@johnnolan
Copy link
Contributor Author

johnnolan commented May 24, 2021

Updated the description to better describe the issue being missing docs rather than it being an implied Heroku issue

@gregtyler
Copy link
Contributor

When this component is written up, it should include some guidance noting that if you have the same button present on multiple panels (e.g. "View" or "Edit") then you should use .govuk-visually-hidden to differentiate them for a screen reader

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants