Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 照会処理を統一 #15536

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Feb 22, 2025

What

照会を行い、ap/showのレスポンスを返す部分までを共通の関数に抜き出した

Why

Fix #15533

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Feb 22, 2025
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 14.58%. Comparing base (7c87dec) to head (b47434b).

Files with missing lines Patch % Lines
packages/frontend/src/scripts/lookup.ts 0.00% 42 Missing ⚠️
packages/frontend/src/pages/search.note.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15536       +/-   ##
============================================
- Coverage    40.86%   14.58%   -26.28%     
============================================
  Files         1609      770      -839     
  Lines       161806    68500    -93306     
  Branches      3786     1305     -2481     
============================================
- Hits         66119     9990    -56129     
+ Misses       95239    58081    -37158     
+ Partials       448      429       -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
1 participant