Skip to content
This repository has been archived by the owner on Jul 20, 2020. It is now read-only.

Support for Scala 2.12.x #3

Open
XerxesDGreat opened this issue Jun 21, 2017 · 8 comments
Open

Support for Scala 2.12.x #3

XerxesDGreat opened this issue Jun 21, 2017 · 8 comments

Comments

@XerxesDGreat
Copy link

Are there any plans to support Scala version 2.12.x? I've cloned the repo, manually compiled against 2.12.2, and run the app and it seems to work properly. Are there any considerations about which you're concerned?

@mitallast
Copy link
Owner

Now I do not actively maintain this client, since I do not have active projects using it.
There's no scala dependencies, no extra language features used - it should word on scala 2.12, if tests passed ok.

@XerxesDGreat
Copy link
Author

great, thanks! If everything works with scala 2.12, would you like a PR to add cross-compile support for both 2.11 and 2.12?

@mitallast
Copy link
Owner

This is will be great

@tunesmith
Copy link
Contributor

I added a PR for 2.12 here: #5

@tunesmith
Copy link
Contributor

Hi @mitallast, any chance you might be able to review this PR and push out a release if this is acceptable?

@mitallast
Copy link
Owner

Hi, @tunesmith!
Sorry for long response. I'm do release at hour

PS. Do you want be an maintainer/owner of this library?

@mitallast
Copy link
Owner

published to sonatype repo

@tunesmith
Copy link
Contributor

I'd be happy to be added as maintainer/owner if I'm not the only one. :-) I am not as familiar with the code as you. Thank you for merging and releasing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants