Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove New Design Feature Flag #1864

Closed
3 of 5 tasks
jkachel opened this issue Sep 5, 2023 · 1 comment · Fixed by #2064
Closed
3 of 5 tasks

Remove New Design Feature Flag #1864

jkachel opened this issue Sep 5, 2023 · 1 comment · Fixed by #2064

Comments

@jkachel
Copy link
Contributor

jkachel commented Sep 5, 2023

Checklist of things to do when de-flagging the new design:

  • Remove calls to is_enabled
  • Specifically remove flagged block from cms/templates/product_page.html
  • Remove catalog view
    def catalog(request, **kwargs):
    and update url path to reference index view.

Tabled:

  • Clean up flagged CSS - remove CSS classes that are for the old design
  • Audit static images included in the repository. I'm guessing that some of these are no longer used in the new design.
@jkachel
Copy link
Contributor Author

jkachel commented Jan 18, 2024

Notes about the CSS auditing: I de-new-designed the CSS and noted that there are some pages that still have old bits. Those are:

  • Sign In - uses old fonts and background color
  • Financial Assistance - uses old background and old footer
  • Edit Profile - uses old fonts and background color
  • Account - uses old fonts and background color
  • Dashboard - uses old fonts and background color, cards need updating to look right
  • Program Record - uses old fonts and background color
  • Order History - uses old fonts and background color; table needs to be updated for new design

Some of these changes are pretty straightforward but some aren't. I did not modify the CSS classes that are being used in components and templates, so not modifying the CSS or images. I don't think the Figma design for this included these pages - it was more concerned with the product pages. We can likely make some basic changes but it'd be better to get some actual design input first. I will split this out into a separate issue for that purpose.

The work I did for deflagging the CSS is here: https://github.com/mitodl/mitxonline/tree/jkachel/1864-pt-2-deflag-css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants