Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User dropdown menu updates #1899

Merged
merged 4 commits into from
Sep 19, 2023
Merged

User dropdown menu updates #1899

merged 4 commits into from
Sep 19, 2023

Conversation

annagav
Copy link
Contributor

@annagav annagav commented Sep 18, 2023

What are the relevant tickets?

Fix #1898

Description (What does it do?)

Adding styling update:

  1. The dropdown menu arrow has now transition through rotation, better centering, and less thick
  2. There is a light grey bar to the left of the learners name
  3. The dropdown menu items are differently positioned when the menu is open

Screenshots (if appropriate):

Before:
Screen Shot 2023-09-18 at 11 43 00 AM

After:
Screen Shot 2023-09-20 at 8 35 56 AM

How can this be tested?

Log in as a users and play around the the top right menu.

@annagav annagav changed the title User dropdoen menu updates User dropdown menu updates Sep 18, 2023
@rachellougee rachellougee self-assigned this Sep 19, 2023
Copy link
Contributor

@rachellougee rachellougee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

border-radius: 0 0 3px 3px;
}
}
.top-user-menu.dropdown {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line and .dropdown-menu could probably wrap inside a .top-user-menu {} block for readability.

@annagav annagav merged commit 38b9992 into main Sep 19, 2023
@annagav annagav deleted the ag/header_design_fixes branch September 19, 2023 19:23
@odlbot odlbot mentioned this pull request Sep 19, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styling updates to the new header design
2 participants