Course Calatog: Stay on selected department #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachellougee
approved these changes
Sep 26, 2023
| @@ -722,14 +722,14 @@ describe("CatalogPage", function() { | |||
|
|
|||
| // Change to the programs tab. | |||
| inner.instance().changeSelectedTab("programs") | |||
| // Confirm that the selected departement resets to "All Departments". | |||
| expect(inner.state().selectedDepartment).equals("All Departments") | |||
| // Confirm that the selected department resets to "All Departments". | |||
There was a problem hiding this comment.
Minor: This comment doesn't match with code now. Is this test still needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fix #1919
Description (What does it do?)
Don't switch departments when courses or programs tab is selected.
How can this be tested?
Go to catalog page. Select a department, switch to the programs tab. The same department should be selected.