Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificates use product title #2024

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Certificates use product title #2024

merged 1 commit into from
Dec 13, 2023

Conversation

annagav
Copy link
Contributor

@annagav annagav commented Dec 11, 2023

What are the relevant tickets?

Fix https://github.com/mitodl/hq/issues/2696
Fix #2003

Description (What does it do?)

Updates the program and course certificate to use the title of the product.

Screenshots (if appropriate):

Screen Shot 2023-12-11 at 12 26 20 PM

How can this be tested?

Create a course certificate, create a course certificate page in wagtail.
View the certificate. Make sure it looks as expected.

Repeat the same with a program certificate.

@annagav annagav force-pushed the ag/certificate_course_title branch from 48e098f to ec43491 Compare December 11, 2023 23:33
@jkachel jkachel self-assigned this Dec 13, 2023
Copy link
Contributor

@jkachel jkachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I was able to create course and program certs and update the titles only by changing the underlying program or course title.

@annagav annagav merged commit c7e299b into main Dec 13, 2023
3 checks passed
@annagav annagav deleted the ag/certificate_course_title branch December 13, 2023 16:32
@odlbot odlbot mentioned this pull request Dec 13, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use program title for program certificate template
2 participants