Fix program id retrieval when sharing #2061
Conversation
| @@ -77,7 +77,7 @@ export class LearnerRecordsPage extends React.Component<Props, State> { | |||
| } | |||
|
|
|||
| getOnlyProgramId() { | |||
There was a problem hiding this comment.
What is the difference between getOnlyProgramId and getProgramId?
There was a problem hiding this comment.
I also had that question. I think the getOnlyProgramId does the same thing getProgramId without the check for return this.props.match.params.program.length !== 36. But we should ask @jkachel for the meaning behind it.
There was a problem hiding this comment.
were you able to test "Allow Sharing" on the program records?
There was a problem hiding this comment.
Yes, this works for me. But that mystery "36" in the similar function should be figured out before approving.
There was a problem hiding this comment.
The URLs are the same if you're viewing for a program or a shared record. The shared records use a UUID, hence 36. Neither of these two functions are named particularly well; getProgramId is really a check for a shared program record where getOnlyProgramId only returns if there's a program ID (aka an int).
annagav
force-pushed
the
ag/get_program_id
branch
from
7c9c539 to
1a9fcb8
Compare
There was a problem hiding this comment.
So I have a program with 2 required courses. I also have a program certificate. When I load the program record page I am seeing an error in the console and the program sharing buttons are not displayed. When I switch back to the main branch, this does not occur.
| ? this.props.match.params.program | ||
| : false | ||
| isProgramRecordShared() { | ||
| return this.props.match.params.program.length === 36 |
There was a problem hiding this comment.
I would add a comment indicating what the 36 number is and how it's used.
annagav
force-pushed
the
ag/get_program_id
branch
from
c7d46ce to
95c8cc4
Compare
What are the relevant tickets?
Fix #2056
Description (What does it do?)
Fixes a bug when getting the program id.
How can this be tested?
Go to view your program record, click enable sharing, check that sharing request was called with the correct program id.