Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor App and HeaderApp to merge common functionality #235

Open
gsidebo opened this issue Sep 29, 2021 · 1 comment
Open

Refactor App and HeaderApp to merge common functionality #235

gsidebo opened this issue Sep 29, 2021 · 1 comment

Comments

@gsidebo
Copy link
Contributor

gsidebo commented Sep 29, 2021

This is a holdover from mitxpro, which suffers from the same debt.

App.js and HeaderApp.js have a large amount of duplicated code, and almost every time we add functionality to one, we have to do the exact same for the other. Aside from the extra code maintenance, we run the risk of these two files diverging and experience unexpected behavior and bugs between the CMS- and React-based portions of the app. We should refactor them to abstract away the common logic.

@gsidebo
Copy link
Contributor Author

gsidebo commented Dec 3, 2021

Related issue in mitxpro: mitodl/mitxpro#500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant