-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Learning MFE Header to frontend-component-header MFE #252
Move Learning MFE Header to frontend-component-header MFE #252
Comments
@pdpinch FYI |
Hi there - I'd suggest that Feel free to tag me if I can help answer questions here - this was brought up in the Frontend Working Group's meeting today, where we were pleased to see this issue! |
Another note - I think if we leave |
@davidjoy Thanks for the input. I will try to create an upstream PR first for the some possible changes in frontend-component-header. |
Related to #112
As per some suggestion by David, We need to refactor the code in EdX Learning MFE to utlize the header from
frontend-component-header
instead of course-headerAcceptance Criteria:
Create an upstream PR to edx frontend-component-header repository with the following criteria
src
directory of frontend-component-header (May be custom directory with name of/src/headers
and introduce this course-header asLearningHeader
there and can be used to add new header asStudioHeader
in future.LearningHeader
- [ ] frontend-component-header MFE should export theCourseTabsNavigation
component.frontend-component-header-edx
so that edx.org's build process doesn't explode, since the site runs on master#### Once the Code integrated infrontend-component-header
andfrontend-component-header-edx
#### NOTE: We can move the below details into another story.Create an upstream PR to frontend-app-learning repository with the following criteria:- [ ] The code related to course-header should be removed from the repository.- [ ] Introduced the@edx/frontend-component-header
in package.json.- [ ] Import the headerimport { LearningHeader as Header } from '@edx/frontend-component-header';
instead ofimport { Header } from '../course-header';
NOTE: After that, we will be able to use the npm aliases as described.~~
Out of Scope
The text was updated successfully, but these errors were encountered: