Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard shouldn't lnk to a course that hasn't started #932

Open
pdpinch opened this issue Sep 2, 2022 · 2 comments
Open

Dashboard shouldn't lnk to a course that hasn't started #932

pdpinch opened this issue Sep 2, 2022 · 2 comments
Assignees

Comments

@pdpinch
Copy link
Member

pdpinch commented Sep 2, 2022

Steps to Reproduce

  1. Enroll in a course with a start date in the future
  2. Click the course title in the dashboard

Expected Behavior

  • The course title should be a link when the course hasn't started. There's no place to go yet.
  • It might be nice to have some kind of message if the user does click on the course -- e.g. "Course starts xx/yy/zz at time" -- but I don't think we have an appropriate design at this time.

Actual Behavior

  • link goes to open edX
  • open edX redirects to the open edX dashboard
@jkachel jkachel self-assigned this Sep 2, 2022
@jkachel
Copy link
Contributor

jkachel commented Sep 2, 2022

Testing this on rc with [email protected] and can't reproduce - the code that determines if the title should be linkable already considers the course's start date. I enrolled in Test External Course and set the start date to 2023 and I don't get a link in the card. Is there an account I can use that's doing this?

@arslanashraf7
Copy link
Contributor

arslanashraf7 commented Sep 6, 2022

Just adding more to what @jkachel mentioned, I think when a user is logged in through staff/admin account they still see the link even when the link will be disabled for learners. I think we intentionally did it at some point in #207.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants