Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CKEditor ResourceLink plugin attribute name #1051

Open
ChristopherChudzicki opened this issue Feb 23, 2022 · 1 comment
Open

Change CKEditor ResourceLink plugin attribute name #1051

ChristopherChudzicki opened this issue Feb 23, 2022 · 1 comment
Assignees

Comments

@ChristopherChudzicki
Copy link
Contributor

Our ResourceLink plugin for CKEditor relies on HTML anchor tags having a data-uuid attribute. The attribute value previously was a uuid. It is no longer a UUID, but rather some string encoding encoding (1) a uuid and (2) possibly some other information.

We use a single attribute to pass this data to CKEditor because that's most convenient as far as CKEditor is concerned

Suggested new name: data-link-attrs.

See discussion at #1036 (comment)

@alicewriteswrongs
Copy link
Contributor

In order to change this we'll need to make a change over in https://github.com/mitodl/ckeditor5 and publish a new version of our forked package (https://www.npmjs.com/package/@mitodl/ckeditor5-resource-link) which has the change. The change should be just changing a constant value.

Then once we have that released, we can introduce a PR in Studio to update to the new package and make the necessary changed to our ResourceLinkMarkdownSyntax plugin (which, again, will be basically just changing one constant value)

@ChristopherChudzicki ChristopherChudzicki self-assigned this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants