-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images inside links #1130
Comments
I'll assign this to myself until we decide what to do about these |
FYI, I just met with the OL accessibility expert and she told me that we should not continue using the hidden image with alt tag to flag "inaccessible" PDFs. She claims that many more PDFs are accessible than we think, and that it's no safe for us to assume what a user can or wants to get out of file. It's sufficient to indicate that it's a PDF. And, if we really wanted to be helpful, we would have a note that explains the content of the PDF, rather then just tell users "this isn't for you." In practice, this means that we should strip out all the |
This will be addressed by a combination of:
|
I'm pretty sure these should be removed, but I'll need to check with the OCW team. |
@pdpinch If we do want to remove these, can you clarify whether we want to remove just the image or the whole "Buy at Amazon" thing? I.e, does
become
|
In reply to #1130 (comment) The link to purchase at Amazon should be removed. The answer is #2 above. |
Issue: Survey usage of images as "titles" for links in OCW content.
Results
Links inside images have been problematic for CKEditor editing. The "link title" (which is an image) tends to get extra escapes the content is saved in CKEditor. There are two categories
[< resource resource_uuid >](link url)
[](link url)
To reolve (1), we've discussed adding an href-like param to the
< resource >
shortcode and changing CKEditor to preserve those params.That approach will not resolve Issue type (2). There are about ~1900 of type (2) image links, but most are:
trans.gif
thing... Example: This legacy OCW site ... below "Functions of Two Variables Mathlet" there is some highlightable invisible text. If you inspect it in the dev console, it's some weird invisible links with images inside them.There are about 120 of type (2) that do not fall in the above categories, but they are fairly limited in scope. (See this google sheet for more details):
Google Sheet: https://docs.google.com/spreadsheets/d/11uxB165n3DKAjcExBnE4VNDM2p37zOQV3f_I1viIy4M/edit#gid=1372806831
SQL Queries: (In case we want to rerun this) queries.txt
The text was updated successfully, but these errors were encountered: