Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misleading error message when trying to create a site with non-latin characters #128

Open
alicewriteswrongs opened this issue Mar 19, 2021 · 1 comment

Comments

@alicewriteswrongs
Copy link
Contributor

Steps to Reproduce

try a string like "这是我的“ or "русский язык"

Expected Behavior

If we disallow certain characters there should be an error that says something like "Sorry, you've got to stick to latin characters here"

Actual Behavior

Screenshot from 2021-03-19 12-35-38

it incorrectly says the issue is that the field isn't filled in.

Strangely, if you add some text in latin characters, so the title is somehting like "это мой website" or "这是我的website" then it seems to work alright, and the site name works correctly. Only the latin characters show up in the URL slug though:

Screenshot from 2021-03-19 12-40-12

@mbertrand
Copy link
Member

mbertrand commented Dec 16, 2021

There was a preliminary PR (#134) to deal with this but no final decision was made on whether non-latin characters should be allowed and the best way to handle them if yes, so it was never merged. The PR branch is very out of date now but still exists at mb/slugform

@mbertrand mbertrand removed their assignment Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants