-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource and Course collections URLs use a mix of underscores and dashes #947
Comments
I think I think definitely good to do this before we go live and links need to be final, if we're going to do it @gumaerc might have some thoughts about changing the |
I have been meaning to ask if there's a better name we want in the URL, like whether course collections should be under |
The |
right folder! Am I right in thinking that if we changed the |
by folders in the theme, I mean doing something like the following: mv www/layouts/course_collections www/layouts/course-collections |
In theory that would work, yea. Keep in mind that in some scenarios Hugo has trouble with hypens in filenames and / or metadata keys though. For instance, this code would not work:
It would give you an error about |
Ok, that all makes sense to me. If we want to go forward with this rename it would need to happen in ocw-hugo-themes and in ocw-hugo-projects (and then we could have some corresponding changes in our checked in files in this repo) |
The path for Resource collections is
/resource_collections/
but the slug for Resource Collection pages substitutes spaces with dashes. This leads to confusing URLs like https://ocw-draft-qa.global.ssl.fastly.net/resource_collections/open-textbooks/ and https://ocw-draft-qa.global.ssl.fastly.net/course_collections/open-learning-library/Acceptance Criteria:
The text was updated successfully, but these errors were encountered: