Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial focus is sub-optimal on the 'confirm' dialog for course content editor panel #955

Open
alicewriteswrongs opened this issue Feb 2, 2022 · 0 comments

Comments

@alicewriteswrongs
Copy link
Contributor

alicewriteswrongs commented Feb 2, 2022

Steps to Reproduce

Initial focus is on the 'X' in the corner, so to get to the 'Discard changes' button you need to press tab once.

Expected Behavior

I think when the 'You have unsaved changes. Are you sure you want to discard your changes?' dialog opens the initial focus should be on the 'Discard changes' button. That way you have two ways, via the keyboard, to go forward: press enter to discard changes, or press escape to cancel. Cancelling via the 'Cancel' button is also only one tab away.

I'm not sure exactly how we want to adjust this, but I was thinking about things in our editing flow that we might want to adjust to enable people to work more quickly and so on.

Screenshot or Screencast

this shows the (very minor!) issue with this:

Screen.Recording.2022-02-02.at.9.20.02.AM.mov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant