Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify rejections management #31

Open
mmagnuski opened this issue Aug 24, 2014 · 0 comments
Open

Simplify rejections management #31

mmagnuski opened this issue Aug 24, 2014 · 0 comments

Comments

@mmagnuski
Copy link
Owner

🚧 IN PROGRESS

Problems

There are some problems with the current rejections system:

  • rejections are managed inconcistently
  • there is no single, unified function for adding/removing rejections that would take all the mess into account
  • moreover - there seems to be no consensus as to how some things should be handled - most non-obvious cases were just temporary fixes/solutions

Discussion

Handling reject.pre before and after onesec as well as when epoch.distance changes

When onesec has already filled reject.pre:

  • clear distance (and fill reject.pre) to signal that it has been performed
    but this is problematic because we loose info on what epoch.distance was used
    epoch.distance can be moved to datainfo but this also generates some inconsistencies: datainfo with epoch field should mean that epoching has been already performed (and is present in the file) and how

    % distance option, epoching should be checking
    % pre - if it is filled, no need to check
    % distance again. If we change distance -->
    % some reworking is needed to save post
    % but clear pre. May be problematic if
    % pre is empty after distance was applied
    % use .distUsed or internal.distUsed ??

@mmagnuski mmagnuski added this to the v 0.1 milestone Aug 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant