Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compsgui wishlist #53

Closed
6 of 18 tasks
mmagnuski opened this issue Oct 25, 2014 · 4 comments
Closed
6 of 18 tasks

compsgui wishlist #53

mmagnuski opened this issue Oct 25, 2014 · 4 comments

Comments

@mmagnuski
Copy link
Owner

OVERVIEW

pop_selectcomps_new was written with compatibility with pop_selectcomps in mind.
These restrictions turned out to be too limiting so the new version = compsgui works a little different and has a short and easy to type name.
You can use it without db this way: compsgui(EEG)

This issue tracks ideas and considerations about how the function should work and how it could be enhanced.

SPECIFIC TASKS

  • tagging components
  • left and right arrows work as left and right gui buttons
  • explore impact of component removal on signal with (some) other components removed
  • do not save topos in the database
  • right-click - change status
  • position in the centre of the screen
  • size options
  • add page info
  • change visual state only if not the same as in info (in sync)
  • change status colors to those from screenshot
  • grid options (to specify the dimensions of the topo grid)

LATER:

I will think about adding things like:

  • change names to compsgui
  • recover EEG with all the components even if some were marked
  • options for compo plotting
  • getting plotting options from eegDb gui (other GUI)
  • check for figure existence
  • if one resizes the figure the buttons do should not get scaled so much - some limits should be set
  • buttons are sometimes white - gray button backgroundcolor (taken from info) instead of white

CONSIDERATIONS

❓ maybe allow plotting maps without EEG data (maybe ...)

@mmagnuski
Copy link
Owner Author

The work on this function is being done in #52

@mmagnuski mmagnuski removed this from the v 0.1 milestone Nov 9, 2014
@mzakrzewska
Copy link
Collaborator

Not sure at which stage EEG is recovered when getting to pop_selectcomps_new by ctr-e, but it should do the 'ICAnorem' recover by default - as it is now, you can't inspect (or un-reject) previously rejected components.

@mmagnuski
Copy link
Owner Author

True, this will have to be changed but along with #28. (but you can un-reject)
The idea is that the recovered file should be recovered without rejections - only filtered and epoched.
Removing epochs and components is fast so it can be performed on the fly - and would reduce wait time if component rejections or epoch rejections are changed (no need to filter again).
Currently you cannot inspect components rejected previously, but you do not have to recover again. If you press 'c' in the main window (multiple topoplots) to compare changes with all rejected components - you get a warning that some are already rejected. See szoppracz for this.

@mmagnuski
Copy link
Owner Author

For link between winreject and this function look for linkfun_ + thisfunctionname m file.

@mmagnuski mmagnuski changed the title pop_selectcomponents_new compsgui wishlist Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants