Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onesecepoch cleanup #94

Open
4 tasks
mmagnuski opened this issue Feb 12, 2017 · 0 comments
Open
4 tasks

onesecepoch cleanup #94

mmagnuski opened this issue Feb 12, 2017 · 0 comments

Comments

@mmagnuski
Copy link
Owner

mmagnuski commented Feb 12, 2017

  • name is a bad description of what the function does; segment_continuous or just segment_eeg would be better. Current segment_eeg segments epochs so should be renamed or thrown away (this is almost never used...)
  • add english docs
  • rewrite window selection to:
    • loop through relevant events, not windows (would be easier to read)
    • accept distances like [2, 4] (not closer than 2 secs, but not further than 4 secs) or [-4, -2] etc.
    • vectorize a little more
  • anything (including window selection) that would be useful outside onesecepoch should be taken out and made a separate function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant