Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bug in OrthographicCamera::GenerateRay of pbrt-v3 #315

Open
stanleyljl opened this issue Dec 21, 2021 · 0 comments
Open

A bug in OrthographicCamera::GenerateRay of pbrt-v3 #315

stanleyljl opened this issue Dec 21, 2021 · 0 comments

Comments

@stanleyljl
Copy link

At the line 61 of orthographic.cpp，It seems that ray->o should be pCamera + Point3f(pLens.x, pLens.y, 0).
It is more reasonable that the ray starts from a region around with pCamera for an ortho camera.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stanleyljl