Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on option to use "un-cleaned" epochs for decoding (omitting ICA / SSP) #808

Closed
hoechenberger opened this issue Nov 2, 2023 · 3 comments · Fixed by #819
Closed

Add on option to use "un-cleaned" epochs for decoding (omitting ICA / SSP) #808

hoechenberger opened this issue Nov 2, 2023 · 3 comments · Fixed by #819
Labels
easy enhancement New feature or request mvpa

Comments

@hoechenberger
Copy link
Member

hoechenberger commented Nov 2, 2023

My sense is that things like SSP and ICA probably won't matter but that peak-to-peak rejection could help, depending on the nature of the artifacts. That sounds in line with what you're seeing @hoechenberger . In this case it makes sense for us to use the "clean" epochs for decoding. At some point we could make it an option which to use (but maybe assume YAGNI for now?)

Originally posted by @larsoner in #796 (comment)

@hoechenberger hoechenberger added enhancement New feature or request easy mvpa labels Nov 2, 2023
@hoechenberger
Copy link
Member Author

@larsoner I may be able to make a PR for this tonight or tomorrow. We can then cut a release and include 1.5 in the installer.

Q: should we jump to 1.6 directly to match the MNE version?

@larsoner
Copy link
Member

I don't think we should try to match the MNE version. Maybe in this project we can take SEMVER seriously and make it 2.0. I'm sure we have a breaking change in here somewhere :)

@hoechenberger
Copy link
Member Author

hoechenberger commented Nov 14, 2023

I'm still a big fan of date-based versioning but if that's off the table still, I'm all for serious SemVer like you proposed, even if that means jumping to version 13 by the end of next year or so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy enhancement New feature or request mvpa
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants