Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChargePoint._handle_call return response #539

Closed
wafa-yah opened this issue Dec 5, 2023 · 1 comment
Closed

ChargePoint._handle_call return response #539

wafa-yah opened this issue Dec 5, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@wafa-yah
Copy link
Contributor

wafa-yah commented Dec 5, 2023

In our app we are logging the OCPP call results:

  • we are currently relying on a decorator that decorates the _on_action ChargePoint handlers.
  • At the level of those handlers we do not have access to the message.unique_id which is a logging requirement, for that we decided to use ChargePoint._handle_call method.
  • By doing so we lost access to the response which is also a required field for the logging.
  • To resolve this, we want to make ChargePoint._handle_call has the response as return value.

So basically the following:

class ChargePoint:
    ....
    ....
    async def _handle_call(self, msg):
        ....
        ....
        return response
@wafa-yah
Copy link
Contributor Author

wafa-yah commented Dec 7, 2023

Resolved: #538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant