Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSQL values not escaped #125

Open
tommydeboer opened this issue May 9, 2019 · 0 comments
Open

RSQL values not escaped #125

tommydeboer opened this issue May 9, 2019 · 0 comments
Labels
🐛 bug Something isn't working

Comments

@tommydeboer
Copy link
Collaborator

tommydeboer commented May 9, 2019

Possible solution: Port our JS RSQL library to Python

How to Reproduce

mcmd add user "henk maria" --with-email [email protected]
mcmd give "henk maria" view dataexplorer

Expected behavior

Command succeeds.

Observed behavior

Field \'q\' of \'entityCollectionRequestV2\' Failed to convert property value of type java.lang.String to required type org.molgenis.web.rsql.QueryRsql for property q; nested exception is org.springframework.core.convert.ConversionFailedException: Failed to convert from type [java.lang.String] to type [org.molgenis.web.rsql.QueryRsql] for value username==henk maria; nested exception is cz.jirutka.rsql.parser.RSQLParserException: cz.jirutka.rsql.parser.ParseException: Encountered " <UNRESERVED_STR> "maria "" at line 1, column 16.\nWas expecting one of:\n <EOF> \n <AND> ...\n <OR> ...\n

✅ If you run mcmd give "'henk maria'" view dataexplorer, the command succeeds again.

@tommydeboer tommydeboer added the 🐛 bug Something isn't working label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant