Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all existent languages #83

Closed
2 of 6 tasks
erciccione opened this issue Jun 30, 2018 · 21 comments
Closed
2 of 6 tasks

Update all existent languages #83

erciccione opened this issue Jun 30, 2018 · 21 comments

Comments

@erciccione
Copy link
Contributor

erciccione commented Jun 30, 2018

Ok folks, the alpha release is close and we have to translate all the missing parts of the existent translations in this repository.

Instructions on how to update a translation can be found in the related wiki section on Taiga, but basically, the files who need to be translated are located in the _i18n folder in this repository. Just make sure the .yml file related to your language is updated along with all the content of the folder.

@erciccione
Copy link
Contributor Author

erciccione commented Jun 30, 2018

Pinging contributors who helped with translations in past. Let me know if any of you can work on this issue. If you are on Taiga and wish to work on a language, please assign the task to yourself and label it as in progress (if you actively started the translation)

Russian: @monerorus @LvMsterfild @kerastinell
Danish: @cryptobench
Spanish: @ordtrogen @lh1008
German: @Rafficer @lovvskillz
French: @el00ruobuob @cryptochangements34
Italian: @qwert95 @hrumag

@el00ruobuob
Copy link
Contributor

I have done the yml. I am updating kovri-docs (work in progress) and will publish the changes in a week or two.

This was referenced Jun 30, 2018
@erciccione
Copy link
Contributor Author

@el00ruobuob thanks, but keep in mind that this issue is about the content of kovri-site not kovri-docs and also the content of the fr folder should be translated

@Josexv1
Copy link
Contributor

Josexv1 commented Jun 30, 2018

I will keep this comment updated with my progress on Spanish kovri-site asi i have it assigned on Taiga

  • modified: kovri.i2p/_data/lang/es/navigation.yml
  • modified: kovri.i2p/_i18n/es.yml
  • modified: kovri.i2p/_i18n/es/acknowledgements.md
  • modified: kovri.i2p/_i18n/es/building.md
  • modified: kovri.i2p/_i18n/es/contributing-docs.md
  • modified: kovri.i2p/_i18n/es/contributing.md
  • modified: kovri.i2p/_i18n/es/faq.md
  • modified: kovri.i2p/_i18n/es/index.md
  • unchanged: kovri.i2p/_i18n/es/intro.md
  • unchanged: kovri.i2p/_i18n/es/legal.md
  • unchanged: kovri.i2p/_i18n/es/quality.md
  • unchanged: kovri.i2p/_i18n/es/style.md
  • unchanged: kovri.i2p/_i18n/es/user-guide.md

The rest will updated in the following days. Only 5 files left.
I took #65 as my base to translate, as we approved the changes, and later we can talk about the right words to use in confusing wordings. If anyone wants to see the files, comment and i will push to my fork.

@erciccione
Copy link
Contributor Author

Thanks @Josexv1 great to have a tracker :) Btw i see you have the whole userstory assigend at the moment, not the task, that can be confusing. I suggest you to "watch" the userstory on taiga, not to assign it to yourself. I'm removing the "assigned to" from the userstory and moving it to the task.

@Josexv1
Copy link
Contributor

Josexv1 commented Jun 30, 2018

Sure, Taiga has a lot of stuff, so sometimes is confusing, as i have little time to get used to it.

@el00ruobuob
Copy link
Contributor

@erciccione isn't the files recurvisely links from kovri-docs? I think I remember @anonimal mentioning kovri-docs was the main resources to translate.

@Josexv1
Copy link
Contributor

Josexv1 commented Jun 30, 2018

@el00ruobuob is right, kovri-docs/i18n updates kovri-site/kovri.i2p/_i18n as stated in #73 and here

@erciccione
Copy link
Contributor Author

erciccione commented Jun 30, 2018

@el00ruobuob the content of the "docs" page on getkovri and most of the rest of the website is stored on kovri-docs, but yes, now i see, some of the files in kovri-site are still a duplicate of the content of kovri-docs.

This is very confusing and i already asked in past to clarify which files have been ported to kovri-docs and which weren't. @rehrar @anonimal Guys, i really need a clarification here. I have to say the communication with me about kovri-related localizations has been very poor and almost not existent in the past months (talking about the localization of the website, not the README or other recent works). I really need to receive more instructions/updates from the Kovri team or i will end up asking our translators to work on something that will not being used or it's a duplicate.

it's not easy for me to follow the updates of every single monero-related project i take care of (they are about 8-9 at the moment), i really need a better communication from your side. @rehrar i remember i specifically spoke to you about this issue on #monero-translations long ago, this has been untouched for months and an issue was opened just recently (#73 ). Please let me know.

Edit: recent examples of what i mean: #72 and #69 have been opened for more than 2 weeks and we still don't know how to deal with those sections. Today @el00ruobuob asked to me and the only think i could suggest was to make the same question on #kovri-dev. That's not good.

@Josexv1
Copy link
Contributor

Josexv1 commented Jun 30, 2018

We need to have a meeting with translators that way we can create or edit the README with clear instructions, on which files to touch and what files are automatically created/updated for translators to work with. Actually when we clone the repo, we have these 2 folders with files. I'm using right now the kovri-site/kovri.i2p/_i18n for translation, so if things change i will switch to the kovri-docs repo.

@erciccione
Copy link
Contributor Author

We need to have a meeting with translators that way we can create or edit the README with clear instructions, on which files to touch and what files are automatically created/updated for translators to work with

The point is that this is not something that the localization team should figure out, we (or at least I) should be instructed on what is to translate and what have been changed and how to deal with it, so that i can give to translators updated instructions. That's what i'm asking.

@el00ruobuob
Copy link
Contributor

@erciccione if we look at #62 or #61 it looks like we should update the docs from kovri-docs, and not from kovry-site. But @rehrar, @anonimal, or @oneiric should confirm.

@erciccione
Copy link
Contributor Author

looks like we should update the docs from kovri-docs, and not from kovry-site.

Yes, i'm aware of that. the problem is that it's not clear for me which part of monero-site should be translated except the .yml language files and which parts are duplicated/not used anymore

@anonimal
Copy link
Collaborator

anonimal commented Jul 2, 2018

2018-07-02 18:51:47     anonimal        Thanks erciccione_[m] you are amazing
2018-07-02 18:53:04     anonimal        https://github.com/monero-project/kovri-site/issues/73 really screwed the pooch for translators
2018-07-02 18:53:26     anonimal        I see josexv1 doing translation work on files that shouldn't exist in the kovri-site repo https://github.com/monero-project/kovri-site/issues/83#issuecomment-401540319
2018-07-02 18:53:56     anonimal        They are out of date, shouldn't be translated, and shouldn't exist in the repo.
2018-07-02 18:54:09     anonimal        I really hope rehrar returns to help clean this up
2018-07-02 18:55:26     anonimal        erciccione_[m]: priority is translating the kovri readme like you did. 2nd is making sure all non-english languages are translated exactly as seen in the english folder (new layout, new files). 3rdly, the website (because the website is supposed to pull from kovri-docs repo).
2018-07-02 18:55:44     anonimal        Does that make sense?

These comments apply to this issue too. @erciccione Yes, @rehrar really screwed the pooch here and I've not been maintaining the site because I'm busy with everything else. I propose the following:

  1. 1st priority is translating the kovri readme in all languages, like you did, @erciccione.
  2. 2nd is making sure all non-english languages in kovri-docs are translated exactly as seen in the english folder (new layout, new files) in the kovri-docs repo.
  3. 3rdly, the website (because the website is supposed to pull from kovri-docs repo).

By the time the first 2 points are done, hopefully @rehrar will have returned to help clean this up.

@el00ruobuob
Copy link
Contributor

el00ruobuob commented Jul 2, 2018

Thanks @anonimal. Regarding 2:

making sure all non-english languages in kovri-docs are translated exactly as seen in the english folder (new layout, new files) in the kovri-docs repo.

Does this mean we should clean up the directories? And only keep the exact same files?

@anonimal
Copy link
Collaborator

anonimal commented Jul 2, 2018

Yes.

@Josexv1
Copy link
Contributor

Josexv1 commented Jul 2, 2018

I'm changing the translation details to kovri-docs. Will update the list on the other comment when i can.

@erciccione
Copy link
Contributor Author

1st priority is translating the kovri readme in all languages, like you did, @erciccione.

OK, will geve instructions to start with this, then we will move to the second point. Thanks for the clarification @anonimal

@erciccione
Copy link
Contributor Author

just opened monero-project/kovri-docs#59 @anonimal please merge ASAP so we can start working on point 1 of the list.

@anonimal
Copy link
Collaborator

anonimal commented Jul 3, 2018

Merged.

@anonimal
Copy link
Collaborator

anonimal commented Sep 7, 2018

NOTICE: THIS ISSUE HAS BEEN MOVED TO GitLab. Please continue the discussion there. See #122 for details.

@anonimal anonimal closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants