Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Implement CRL handling #154

Closed
1 task done
anonimal opened this issue Mar 5, 2016 · 1 comment
Closed
1 task done

Implement CRL handling #154

anonimal opened this issue Mar 5, 2016 · 1 comment
Labels
crypto design enhancement libclient minor

Comments

@anonimal
Copy link
Collaborator

anonimal commented Mar 5, 2016

By submitting this issue, I confirm the following:

  • I have read and understood the contributor guide.
  • I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.
  • I have checked opened or recently closed pull requests for existing solutions/implementations to my issue/suggestion.

Place an X inside the bracket to confirm

  • I confirm.

As discussed in today's meeting, we would receive any CRL's via our http/https auto-update channel. Referencing #48. Topic discussion at http://zzz.i2p/topics/2058-proposal-crls-in-the-news-feed
anonimal added a commit to anonimal/kovri that referenced this issue Sep 5, 2016
@anonimal
HTTP/AddressBook: major refactoring + download impl
add429b 
Major:
- Implementation improvements
  * HTTP: download impl
  * HTTP: URI handling impl
  * HTTP: response header handling for clearnet
  * AddressBook: unhook in-net HTTP impl (now in class HTTP)
  * Add documentation

Medium:
- If default subscription file does not exist,
  create/save after downloading from publisher

Minor:
- Adjust related reseed and tunnel code for class HTTP
- Update variables names to accurately reflect purpose
- Update log messages for accuracy
- Update address book flow narrative
- Update/improve HTTP unit-test

References:
- monero-project#305 (parent ticket)
- monero-project#168 and monero-project#155 (both in terms of HTTP/S)
- monero-project#154 and monero-project#48 (we now have a multi-purpose HTTP/S download impl)

Notes:
- My apologies for not keeping this commit atomic.
  Bigger design work can be harder to keep atomic
  (especially if one wants new features to work before committing)
- This commit has been successfully tested and all unit-tests pass
@anonimal
Copy link
Collaborator Author

anonimal commented Sep 7, 2018

NOTICE: THIS ISSUE HAS BEEN MOVED TO GitLab. Please continue the discussion there. See #1013 for details.

@anonimal anonimal closed this as completed Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
crypto design enhancement libclient minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anonimal