Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Question the singleton design #34

Closed
anonimal opened this issue Nov 20, 2015 · 1 comment
Closed

Question the singleton design #34

anonimal opened this issue Nov 20, 2015 · 1 comment
Labels
design minor

Comments

@anonimal
Copy link
Collaborator

Do we needs this? If so, why? Is it worth keeping? I think it causes more problems than solves. Apparently it is helpful for Windows.

2015-11-15 21:31:20     mlt-    btw
2015-11-15 21:31:26     mlt-    not that it might be relevant
2015-11-15 21:31:52     mlt-    but when I attempted to use orignal's libi2pd as dll, there was an issue with exported variables
2015-11-15 21:32:00     mlt-    across DLL /shared object boundary
2015-11-15 21:32:06     mlt-    it is tricky on Windows
2015-11-15 21:32:22     mlt-    and it is easier to export a function, read singleton,
2015-11-15 21:33:13     mlt-    bottom line, on some platforms, it might be a PITA to export gloval variable across shared object
@anonimal anonimal added the minor label Nov 22, 2015
This was referenced Nov 30, 2015
Closed
Closed
Closed
@anonimal anonimal added the design label Dec 3, 2015
@anonimal anonimal mentioned this issue Feb 2, 2016
Closed
@moneromooo moneromooo mentioned this issue Oct 2, 2016
Closed
1 task
anonimal added a commit to anonimal/kovri that referenced this issue Dec 1, 2016
@anonimal
Instance/Configuration: begin unhooking out of singleton
400ce4e 
- Not entirely unhooked, but a start in that direction:
  * create new Instance class which handles:
    - configuration/initialization of client/router contexts
    - reloading of client/server tunnels
  * aims to detach from daemon and handle *all* client/router aspects
    - many new TODO's with detailed explanatory remarks

- Configuration refactor:
  * ctor initializes with cli arguments, sets config member
  * now using program_options::command_line_parser
  * throw instead of return bool when parsing
  * move out of util directory

- Misc refactoring to satisfy the above, misc. TODO's related to above

References monero-project#96 monero-project#34
@anonimal anonimal mentioned this issue Dec 3, 2016
Merged
1 task
@anonimal
Copy link
Collaborator Author

anonimal commented Sep 7, 2018

NOTICE: THIS ISSUE HAS BEEN MOVED TO GitLab. Please continue the discussion there. See #1013 for details.

@anonimal anonimal closed this as completed Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
design minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anonimal