Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Remove crypto's pimpl idiom #785

Closed
anonimal opened this issue Jan 4, 2018 · 1 comment
Closed

Remove crypto's pimpl idiom #785

anonimal opened this issue Jan 4, 2018 · 1 comment

Comments

@anonimal
Copy link
Collaborator

anonimal commented Jan 4, 2018

We don't need it, I never wanted it, it's annoying to deal with and it's unneeded overhead. Crypto++ is a fine library of which I've worked side-by-side with and I don't foresee it leaving anytime soon. We also don't change our crypto enough to warrant a pimpl design so, simply treating our implementation file(s) as implementation files should suffice - without the need for pimpl.

Removing pimpl won't prevent us from changing libraries. If we end up changing any interfaces in the process of resolving this issue, the changes will be for the better.


By submitting this issue, I confirm the following:

  • I have read and understood the contributor guide in kovri-docs.
  • I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.
  • I have checked opened or recently closed pull requests for existing solutions/implementations to my issue/suggestion.

@anonimal
Copy link
Collaborator Author

anonimal commented Sep 7, 2018

NOTICE: THIS ISSUE HAS BEEN MOVED TO GitLab. Please continue the discussion there. See #1013 for details.

@anonimal anonimal closed this as completed Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant