Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

HTTP Proxy: Improve Code Style & Organization in HTTPMessage #844

Closed
coneiric opened this issue Mar 29, 2018 · 1 comment
Closed

HTTP Proxy: Improve Code Style & Organization in HTTPMessage #844

coneiric opened this issue Mar 29, 2018 · 1 comment
Labels
maintenance

Comments

@coneiric
Copy link
Contributor

By submitting this issue, I confirm the following:

  • I have read and understood the contributor guide in kovri-docs.
  • I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.
  • I have checked opened or recently closed pull requests for existing solutions/implementations to my issue/suggestion.

There are a number of glaring style issues with HTTPMessage. Data members should be private, needs new getters/setters for those data members, HTTP + URI components need their own structs, etc.

References #340.
@coneiric coneiric mentioned this issue Mar 29, 2018
Closed
@coneiric coneiric changed the title Improve Code Style & Organization in HTTPMessage HTTP Proxy: Improve Code Style & Organization in HTTPMessage Mar 29, 2018
@anonimal
Copy link
Collaborator

anonimal commented Sep 7, 2018

NOTICE: THIS ISSUE HAS BEEN MOVED TO GitLab. Please continue the discussion there. See #1013 for details.

@anonimal anonimal closed this as completed Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anonimal @coneiric