Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatch between function declaration and definition #8

Open
selsta opened this issue Nov 17, 2021 · 0 comments
Open

Mismatch between function declaration and definition #8

selsta opened this issue Nov 17, 2021 · 0 comments

Comments

@selsta
Copy link

selsta commented Nov 17, 2021 

void sc25519_window4(signed char r[85], const sc25519 *s);

https://github.com/monero-project/supercop/blob/monero/crypto_sign/ed25519/amd64-64-24k/sc25519.h#L58

void sc25519_window4(signed char r[64], const sc25519 *s)

https://github.com/monero-project/supercop/blob/monero/crypto_sign/ed25519/amd64-64-24k/sc25519_window4.c#L3
@selsta selsta mentioned this issue May 28, 2022
Open
jeffro256 pushed a commit to jeffro256/monero-supercop that referenced this issue May 28, 2022
Remedy some GCC warnings
500f438 
The `#ifdef SMALLTABLES` change eliminates the unused variable warning, and the changes to the sc25519_window4 prototype silences the `-Wstringop-overflow=` warnings in GCC.

The prototype seems to be wrong b/c it requires an array of size 85, but the function definition only uses 64 bytes,  the caller expects it only needs 64 bytes, and the 85 seems to be a copy/paste issue from window3 (Props to @moneromooo-monero for finding that)

Resolves monero-project#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@selsta