From 72bf98153f1d910a465663a5af59013004bc4d5d Mon Sep 17 00:00:00 2001 From: Anupama Sarjoshi Date: Fri, 27 Oct 2023 16:18:13 +0100 Subject: [PATCH] Remove unnecessary code from import_from_xml --- questiontype.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/questiontype.php b/questiontype.php index 3051f91..14274a1 100644 --- a/questiontype.php +++ b/questiontype.php @@ -338,15 +338,13 @@ public function import_from_xml($data, $question, qformat_xml $format, $extra = $columns = $format->getpath($data, ['#', 'columns', 0, '#', 'column'], false); if ($columns) { $this->import_columns($format, $question, $columns); - } else { - $question->columns = []; } + $rows = $format->getpath($data, ['#', 'rows', 0, '#', 'row'], false); if ($rows) { $this->import_rows($format, $question, $rows); - } else { - $question->rows = []; } + $format->import_combined_feedback($question, $data, true); $format->import_hints($question, $data, true, true, $format->get_format($question->questiontextformat));