Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.4 Fatal error #68

Open
aspark21 opened this issue May 7, 2024 · 2 comments
Open

4.4 Fatal error #68

aspark21 opened this issue May 7, 2024 · 2 comments

Comments

@aspark21
Copy link

aspark21 commented May 7, 2024

Fatal error: Declaration of qtype_pmatch\testquestion_test_base::assert_same_xml(string $expectedxml, string $xml) must be compatible with question_testcase::assert_same_xml($expectedxml, $xml) in /var/www/html/question/type/pmatch/tests/testquestion_test_base.php on line 235

MOODLE_404_STABLE
PHP8.1
this must be a recent change in core 4.4 as we didn't encounter this in the scoping for 4.4 we did when it was released

@leonstr
Copy link

leonstr commented Jul 1, 2024

This is a result of MDL-81581 in Moodle 4.4.1 which moved assert_same_xml() from qformat_xml\xmlformat_test to the parent of both this and qtype_pmatch\testquestion_test_base.

@leonstr
Copy link

leonstr commented Jul 2, 2024

PR #69 submitted for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants