Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing index 'usermodified' on upgraded installations #98

Open
abias opened this issue Sep 20, 2021 · 1 comment
Open

Missing index 'usermodified' on upgraded installations #98

abias opened this issue Sep 20, 2021 · 1 comment

Comments

@abias
Copy link

abias commented Sep 20, 2021

Hi @timhunt ,

looking at a recent result of the admin/cli/check_database_schema.php tool on our Moodle instance which says

-------------------------------------------------------------------------------
report_customsql_queries
 * Missing index 'usermodified' (not unique (usermodified)). 
CREATE INDEX mdl_repocustquer_use_ix ON mdl_report_customsql_queries (usermodified);
-----------------------------------------------------------------------------

I assume that in 0ba0d70, you have added the new database fields within db/upgrade.php, but haven't added the index as well.

I can fix this locally in our DB, but I think it would make sense if you still would add this to db/upgrade.php and publish a new version.

Thanks in advance,
Alex

TomoTsuyuki added a commit to TomoTsuyuki/moodle-report_customsql that referenced this issue Nov 16, 2021
@TomoTsuyuki
Copy link

Hi @timhunt ,

I made a PR for fixing this issue.
Could you review the PR and merge to fix the issue?

Kind regards,
Tomo

timhunt pushed a commit that referenced this issue Nov 26, 2021
jwalits added a commit to catalyst/moodle-report_customsql that referenced this issue Dec 1, 2021
…webservice/pluginfile

 * separate download endpoint no longer needed, refactor to use new code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants