-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] ctrl-c does not stop another process if one is interactive #1781
Comments
When we receive a signal, we abort all running tasks: https://github.com/moonrepo/moon/blob/master/crates/action-pipeline/src/action_pipeline.rs#L233 But maybe it's because these are persistent tasks already? Let me dig further. |
Give 1.31 a try. |
@milesj Thank you. The issue is there as same as before. When I rerun
|
Can you paste the output with |
First run
Press
|
Hrmm, we should be seeing log lines like this, but we aren't...
Do you see those at all? Perhaps on a fresh run where the zombie process from before doesn't exist. |
No. I killed that zombie process and confirmed again. BYW. I'm using vscode's integrated terminal.
|
I guess |
Yah something weird is going on. Let me mess around with vscode terminal. |
Describe the bug
Steps to reproduce
package.json
moon.yml
pnpm devTest
in terminalctrl-c
pnpm devTest
in terminalrewatch watch
failed because previousrewatch
process doesn't exit as expected.If press
q
then pressctrl-c
instead of justctrl-c
, it's ok.Expected behavior
Screenshots
Environment
Additional context
The text was updated successfully, but these errors were encountered: