Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

num-bigint dependency versions causing issues #132

Open
andygolay opened this issue Jan 28, 2025 · 5 comments · May be fixed by #139
Open

num-bigint dependency versions causing issues #132

andygolay opened this issue Jan 28, 2025 · 5 comments · May be fixed by #139
Assignees
Labels
bug Something isn't working

Comments

@andygolay
Copy link

andygolay commented Jan 28, 2025

🐛 Bug

Reported on X:

"@movementlabsxyz @MovementLabs Heads up - found a num-bigint version conflict in the CLI build. You've got v0.4.4 and v0.2.6 causing type mismatches in Diesel's PG numeric handling. Quick fix would be pinning to 0.4.4 in the deps 🔧"

Image

https://x.com/ateet7tiwari/status/1884317199873237338?s=12&t=tmz-jeomsRJElwoiMA8B5Q

Opening this issue with intent to investigate and will fill out the issue in more detail.

To reproduce

Code snippet to reproduce

# Your code goes here
# Please make sure it does not require any external dependencies

Stack trace/error message

// Paste the output here

Expected Behavior

A clear and concise description of what you expected to happen.

System information

Please complete the following information:

  • Aptos Core Version
  • Rust Version
  • Computer OS

Additional context

Add any other context about the problem here.

@andygolay andygolay added the bug Something isn't working label Jan 28, 2025
@sweatpotato13
Copy link

Downgrade bigdecimal to version 0.3.0 by modifying your Cargo.toml:

bigdecimal = { version = "0.3.0", features = ["serde"] }

This should resolve the issue.

@mzabaluev mzabaluev self-assigned this Feb 6, 2025
@mzabaluev mzabaluev changed the title [Bug] CLI num-bigint dependency versions causing issues Feb 6, 2025
@mzabaluev mzabaluev linked a pull request Feb 6, 2025 that will close this issue
@mzabaluev
Copy link
Collaborator

mzabaluev commented Feb 6, 2025

Reproduced, it's the movement CLI build that is failing.

Downgrade bigdecimal to version 0.3.0

@sweatpotato13 is this preferred to just updating the diesel dependency (#139)?

@sweatpotato13
Copy link

sweatpotato13 commented Feb 6, 2025

Reproduced, it's the movement CLI build that is failing.

Downgrade bigdecimal to version 0.3.0

@sweatpotato13 is this preferred to just updating the diesel dependency (#139)?

It would be better if you could solve it by updating the diesel dependency

The method I suggested is a temporary solution.

@mzabaluev
Copy link
Collaborator

I wish dependencies of the diesel crate weren't so messed up. It should not depend on loose version ranges of num-bigint and bigdecimal when the latter has a more rigid dependency on num-bigint.

@mzabaluev
Copy link
Collaborator

The bigint dependencies are optional for diesel; any opinions on whether the CLI really needs these features?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants