Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issue not finding Ginac #55

Closed
volkm opened this issue Feb 5, 2025 · 11 comments · Fixed by #56
Closed

Build issue not finding Ginac #55

volkm opened this issue Feb 5, 2025 · 11 comments · Fixed by #56

Comments

@volkm
Copy link
Contributor

volkm commented Feb 5, 2025

I have followed all the steps on https://www.stormchecker.org/documentation/obtain-storm/dependencies.html#carl

I still get the error saying that

-- Build files have been written to: /work/cs-grad/tuanle/xSRL/stormpy/pycarl/carl-storm/build/resources/src/Eigen3-EP-build
[ 40%] Performing build step for 'Eigen3-EP'
[ 40%] Performing install step for 'Eigen3-EP'
-- Eigen3-EP install command succeeded. See also /work/cs-grad/tuanle/xSRL/stormpy/pycarl/carl-storm/build/resources/src/Eigen3-EP-stamp/Eigen3-EP-install-*.log
[ 40%] Completed 'Eigen3-EP'
[ 45%] Built target Eigen3-EP
[ 45%] Built target carl_resources
make[3]: *** No rule to make target 'resources/lib/libginac.so', needed by 'libcarl.so.14.28'. Stop.
make[2]: *** [CMakeFiles/Makefile2:450: src/carl/CMakeFiles/lib_carl.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:457: src/carl/CMakeFiles/lib_carl.dir/rule] Error 2

Originally posted by @AlanLeAI in #33

@volkm
Copy link
Contributor Author

volkm commented Feb 5, 2025

Dear @AlanLeAI, can you provide the complete output of the cmake configuration step and the build step? This helps us debug the issue.
Just to clarify: you are manually building carl-storm via the provided steps?

@sjunges
Copy link
Contributor

sjunges commented Feb 5, 2025

Hey!

This looks like a situation where carl would build ginac itself.

I am a bit curious how you got to the path stormpy/pycarl/carl-storm. It would be helpful to tell us a bit what commands you executed.

Sebastian

@AlanLeAI
Copy link

AlanLeAI commented Feb 5, 2025

First, I run the command to install stormpy folder

git clone https://github.com/moves-rwth/stormpy.git

Jump to the stormpy folder

cd stormpy

I run this code python3 setup.py develop

error: subprocess-exited-with-error

× Building wheel for pycarl (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [135 lines of output]
running bdist_wheel
running build
running build_py
creating build/lib.linux-x86_64-cpython-310/pycarl
copying lib/pycarl/init.py -> build/lib.linux-x86_64-cpython-310/pycarl
copying lib/pycarl/_config.py -> build/lib.linux-x86_64-cpython-310/pycarl
copying lib/pycarl/_version.py -> build/lib.linux-x86_64-cpython-310/pycarl
copying lib/pycarl/infinity.py -> build/lib.linux-x86_64-cpython-310/pycarl
creating build/lib.linux-x86_64-cpython-310/pycarl/cln
copying lib/pycarl/cln/init.py -> build/lib.linux-x86_64-cpython-310/pycarl/cln
copying lib/pycarl/cln/_config.py -> build/lib.linux-x86_64-cpython-310/pycarl/cln
creating build/lib.linux-x86_64-cpython-310/pycarl/convert
copying lib/pycarl/convert/init.py -> build/lib.linux-x86_64-cpython-310/pycarl/convert
copying lib/pycarl/convert/cln_converter.py -> build/lib.linux-x86_64-cpython-310/pycarl/convert
copying lib/pycarl/convert/gmp_converter.py -> build/lib.linux-x86_64-cpython-310/pycarl/convert
creating build/lib.linux-x86_64-cpython-310/pycarl/formula
copying lib/pycarl/formula/init.py -> build/lib.linux-x86_64-cpython-310/pycarl/formula
creating build/lib.linux-x86_64-cpython-310/pycarl/gmp
copying lib/pycarl/gmp/init.py -> build/lib.linux-x86_64-cpython-310/pycarl/gmp
creating build/lib.linux-x86_64-cpython-310/pycarl/parse
copying lib/pycarl/parse/init.py -> build/lib.linux-x86_64-cpython-310/pycarl/parse
copying lib/pycarl/parse/_config.py -> build/lib.linux-x86_64-cpython-310/pycarl/parse
creating build/lib.linux-x86_64-cpython-310/pycarl/cln/formula
copying lib/pycarl/cln/formula/init.py -> build/lib.linux-x86_64-cpython-310/pycarl/cln/formula
copying lib/pycarl/cln/formula/_config.py -> build/lib.linux-x86_64-cpython-310/pycarl/cln/formula
creating build/lib.linux-x86_64-cpython-310/pycarl/cln/parse
copying lib/pycarl/cln/parse/init.py -> build/lib.linux-x86_64-cpython-310/pycarl/cln/parse
copying lib/pycarl/cln/parse/_config.py -> build/lib.linux-x86_64-cpython-310/pycarl/cln/parse
creating build/lib.linux-x86_64-cpython-310/pycarl/gmp/formula
copying lib/pycarl/gmp/formula/init.py -> build/lib.linux-x86_64-cpython-310/pycarl/gmp/formula
creating build/lib.linux-x86_64-cpython-310/pycarl/gmp/parse
copying lib/pycarl/gmp/parse/init.py -> build/lib.linux-x86_64-cpython-310/pycarl/gmp/parse
copying lib/pycarl/gmp/parse/_config.py -> build/lib.linux-x86_64-cpython-310/pycarl/gmp/parse
running egg_info
writing lib/pycarl.egg-info/PKG-INFO
writing dependency_links to lib/pycarl.egg-info/dependency_links.txt
writing requirements to lib/pycarl.egg-info/requires.txt
writing top-level names to lib/pycarl.egg-info/top_level.txt
reading manifest file 'lib/pycarl.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'lib/pycarl.egg-info/SOURCES.txt'
running build_ext
-- The C compiler identification is GNU 11.4.1
-- The CXX compiler identification is GNU 11.4.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Python: /work/cs-grad/tuanle/miniconda3/envs/xsrl/bin/python (found version "3.10.16") found components: Interpreter Development Development.Module Development.Embed
-- Pycarl - Using shipped version of pybind11 (version 2.10.0).
CMake Deprecation Warning at build/temp.linux-x86_64-cpython-310/_deps/pybind11-src/CMakeLists.txt:8 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.

    Update the VERSION argument <min> value or use a ...<max> suffix to tell
    CMake that the project does not need compatibility with older versions.

@AlanLeAI
Copy link

AlanLeAI commented Feb 5, 2025

Then, I realized that Stormpy requires Pycarl. I install Pycarl via git clone https://github.com/moves-rwth/pycarl.git inside the stormpy folder.

I install Pycarl via this link https://moves-rwth.github.io/pycarl/installation.html#installation-steps

My Cmake version after running cmake --version is

cmake version 3.29.4

Thank you so much for your help.

@volkm
Copy link
Contributor Author

volkm commented Feb 5, 2025

This only installs the python parts but not the Storm tool. I guess you also installed carl-storm at some point?

For reference, the right order for installation should be:

  1. carl-storm
  2. storm
  3. pycarl
  4. stormpy

@tquatmann
Copy link
Member

I noted a similar issue on a system where carl would build GiNaC itself. (Rocky Linux...)

No rule to make target 'resources/lib/libginac.so', needed by 'libcarl.so.14.28'. Stop.

I noted that libginac.so is located in carl-storm/build/resources/lib64/libginac.so. So I replaced all lib/ by lib64/ in this file which seems to solve the issue for me.

@volkm
Copy link
Contributor Author

volkm commented Feb 5, 2025

Thanks for the info. It seems that Ginac chooses between lib and lib64 depending on some checks. We should probably account for both paths or try out whether --prefix <path> successfully sets the path.

@AlanLeAI
Copy link

AlanLeAI commented Feb 5, 2025

I will try to replaced all lib/ by lib64/ in this file and reply you back. Thank you so much for your help.

@AlanLeAI
Copy link

AlanLeAI commented Feb 6, 2025

Hi after replacing lib/ by lib64/, I can install the carl-storm package now. I am trying to install the storm package via this instructions

https://www.stormchecker.org/documentation/obtain-storm/build.html

after running make, i have this error below. I am so sorry for my lack experience, and I appreciate your help a lot

[ 1%] Creating directories for 'l3pp_ext'
[ 1%] Performing download step (git clone) for 'l3pp_ext'
Cloning into 'l3pp'...
HEAD is now at e4f8d7f Fix some references to log4carl
[ 1%] No update step for 'l3pp_ext'
[ 1%] No patch step for 'l3pp_ext'
[ 1%] No configure step for 'l3pp_ext'
[ 1%] No build step for 'l3pp_ext'
[ 1%] No install step for 'l3pp_ext'
[ 1%] Completed 'l3pp_ext'
[ 1%] Built target l3pp_ext
[ 1%] Creating directories for 'eigen_src'
[ 1%] Performing download step (git clone) for 'eigen_src'
Cloning into 'StormEigen'...
HEAD is now at 0fd6b4f7 Bump to 3.3.9
[ 1%] No update step for 'eigen_src'
[ 1%] Performing patch step for 'eigen_src'
[ 1%] No configure step for 'eigen_src'
[ 1%] No build step for 'eigen_src'
[ 1%] No install step for 'eigen_src'
[ 1%] Completed 'eigen_src'
[ 1%] Built target eigen_src
[ 1%] Creating directories for 'glpk_ext'
[ 1%] No download step for 'glpk_ext'
[ 1%] No update step for 'glpk_ext'
[ 1%] No patch step for 'glpk_ext'
[ 1%] Performing configure step for 'glpk_ext'
CMake Error at /work/cs-grad/tuanle/xSRL/storm/build/resources/3rdparty/glpk-5.0/src/glpk_ext-stamp/glpk_ext-configure-RELEASE.cmake:49 (message):
Command failed: 1

'/work/cs-grad/tuanle/xSRL/storm/resources/3rdparty/glpk-5.0/configure' '--prefix=/work/cs-grad/tuanle/xSRL/storm/build/resources/3rdparty/glpk-5.0' '--libdir=/work/cs-grad/tuanle/xSRL/storm/build/resources/3rdparty/glpk-5.0/lib' 'CC=/usr/bin/cc' 'CXX=/usr/bin/c++'

See also

/work/cs-grad/tuanle/xSRL/storm/build/resources/3rdparty/glpk-5.0/src/glpk_ext-stamp/glpk_ext-configure-*.log

make[2]: *** [CMakeFiles/glpk_ext.dir/build.make:92: resources/3rdparty/glpk-5.0/src/glpk_ext-stamp/glpk_ext-configure] Error 1
make[1]: *** [CMakeFiles/Makefile2:767: CMakeFiles/glpk_ext.dir/all] Error 2
make: *** [Makefile:166: all] Error 2

@volkm
Copy link
Contributor Author

volkm commented Feb 6, 2025

Good to hear that building carl-storm was successful.

To keep a better structure, can you open a new issue for your build error with Storm and GLPK? In the new issue, please also provide the output of the following files as indicated in the error message:

/work/cs-grad/tuanle/xSRL/storm/build/resources/3rdparty/glpk-5.0/src/glpk_ext-stamp/glpk_ext-configure-*.log

@AlanLeAI
Copy link

AlanLeAI commented Feb 7, 2025

I have created a new issue here moves-rwth/storm#667

Thank you so much for your help. I hope that you have a wonderful day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants