Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Ability to Modify a Pending Rejection Date #14920

Open
2 tasks
chrstinalin opened this issue Jul 25, 2024 · 11 comments · May be fixed by mozilla/addons-server#23001
Open
2 tasks

[Task]: Ability to Modify a Pending Rejection Date #14920

chrstinalin opened this issue Jul 25, 2024 · 11 comments · May be fixed by mozilla/addons-server#23001
Assignees
Labels

Comments

@chrstinalin
Copy link

chrstinalin commented Jul 25, 2024

Description

Currently unable to change the date of a pending rejection. If the date needs to be changed, the pending rejection must be deleted and a new pending rejection created in its place. Results in a new rejection email to the developer.

Should have the ability use a date picker to modify the pending rejection date, and either:

  1. Without any additional email, or
  2. With a new email that explains the extended time frame.

Acceptance Criteria

Milestones/checkpoints

Preview Give feedback

Checks

  • If the issue is ready to work on, I have removed the "needs:info" label.
  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@chrstinalin chrstinalin added needs:info repository:addons-server Issue relating to addons-server labels Jul 25, 2024
@chrstinalin
Copy link
Author

Should the email be optional? Should it be implemented as a inline action (similar to setting due_date or clear pending rejections)?

@wagnerand
Copy link
Member

I think given the fact that different versions can have different due dates at the same time, implementing this might not be as straight forward as we initially thought. To do it correctly, you would somehow have to select the versions first for which you want to change the pending rejection date, similar to what you have to do right now when you want to clear the due date.

In any case, any changes affecting the availability or future ability or an add-on or a version, which changing the pending rejection date definitely is, needs to be communicated to the developer. The main goal here was to reduce the effort for reviewers and also send only one email instead of multiple.

However, given the complications mentioned, I am not sure this is something that can be fixed right now, or at least I am not sure how. We can change underlying logic around whether there can be multiple pending rejections (=different dates), but that seems a larger change that needs more consideration.

Thoughts, @diox @mixedpuppy?

@diox
Copy link
Member

diox commented Jul 26, 2024

I agree. Maybe we can address just the simplest scenario though, where all pending rejection dates are the same? It would probably be a specific action with the version dropdown then, and a check when the action is triggered that would throw an error if the current pending rejection dates on the selected versions differ.

@diox
Copy link
Member

diox commented Jul 30, 2024

@wagnerand assigning to you to confirm whether or not my suggestion would solve most cases/be useful enough.

@wagnerand
Copy link
Member

@diox I think that would be sufficient enough for most cases. Let's do that.

@diox
Copy link
Member

diox commented Sep 9, 2024

@wagnerand can you provide the email template to use ?

@wagnerand
Copy link
Member

I asked Ashley via email for the copy.

@wagnerand wagnerand removed their assignment Sep 24, 2024
@wagnerand
Copy link
Member

I asked Ashley to provide the copy in this issue.

@aroybalreid
Copy link

Draft copy is below. Please let me know if you see any issues, or if there are any circumstances where we planned to use this correspondence for which this appears inadequate.

Hello,

As you are aware, your extension {{ Add-on name }} was manually reviewed by the Mozilla Add-ons team, at which point we found a violation of one or more Mozilla add-on policies.

Our previous correspondence indicated that you would be required to correct the violation(s) by {{ old deadline }}. However, after further assessing the circumstances - including the violation itself, the risks it presents, and the steps required to resolve it - we have determined that an alternative timeline is appropriate. Based on that determination, we have updated the deadline, and will now require you to correct your add-on violations no later than {{ new deadline }}.

More information about Mozilla’s add-on policies can be found at https://extensionworkshop.com/documentation/publish/add-on-policies/.

Thank you for your attention.

[{{ cinder_job_id }}]

Mozilla Add-ons Team
https://a.m.o/

@diox
Copy link
Member

diox commented Jan 3, 2025

I have a UI proposal for this that also slightly changes the widget for selecting a pending rejection delay:

  • In "Reject multiple versions", change widget to be a date selector instead 1. Default that date to be + X days to keep existing functionality.
  • Rename "Clear pending rejection" to "Change pending rejection" and re-use the delayed
    rejection widget there. Dynamically change the "Reject immediately" text to show
    "Clear pending rejection" instead in that case.

Screenshots:
Screenshot 2025-01-03 at 17-17-44 Ui-Addon-Install – Add-ons for Firefox
Screenshot 2025-01-03 at 17-18-37 Ui-Addon-Install – Add-ons for Firefox

@wagnerand thoughts ?

Footnotes

  1. the reviewer will just select a date, and the time will be automatic. I propose using the time the action was performed at, so that the automatic rejections continue to be spread out in the day as they are now, but it could be fixed to an arbitrary value instead

@wagnerand
Copy link
Member

wagnerand commented Jan 8, 2025

@diox That all sounds good, thank you. I have actually been wondering for a while whether we should switch to a reviewer specifying an absolute deadline rather than a relative timeline.

One implementation note: Please make sure "Reject immediately" and "Clear pending rejections" are the default actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants