Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly strip/dedent parsed comments #1884

Open
badboy opened this issue Dec 4, 2023 · 0 comments · May be fixed by #1899
Open

Properly strip/dedent parsed comments #1884

badboy opened this issue Dec 4, 2023 · 0 comments · May be fixed by #1899
Assignees
@badboy

Comments

@badboy
Copy link
Member

badboy commented Dec 4, 2023

Initially we took the raw comments in proc-macro code, which means the leading spaces (and trailing) are included.
That's not so much a problem for printing them, because we do the dedent-indent dance.
But since #1878 we now trim all input, which removes too much.

Let's add a proper test case and fix this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@badboy badboy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly dedent doc strings after parsing in the proc-macro mozilla/uniffi-rs
1 participant
@badboy