Add certificates support #1429
Closed
Add certificates support #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, this was useful to get CA signed keys working |
|
It would be greatly appreciated if we could get support for this @mscdex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
He everyone,
This PR adds support for certificates. It works, but breaks some existing tests, and I could use some help resolving the issues.
Tested it with
[email protected]and[email protected]The main problem is that autPK uses pubKey.type or keyAlgo for bouth auth and sign requests.
I’d appreciate any guidance or suggestions to address these issues and make the tests pass.
see mscdex/ssh2-streams#137.