Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(decomposition): Use of bitwise '&' with boolean operands #136

Open
wjrforcyber opened this issue Sep 23, 2024 · 1 comment
Open

Comments

@wjrforcyber
Copy link

wjrforcyber commented Sep 23, 2024

In decomposition.hpp, there's a bit operator & in condition which causes warning:

if ( ( x_xor.first.size() != 0 ) & ( x_xor.second.size() != 0 ) )

warning: use of bitwise '&' with boolean operands [-Wbitwise-instead-of-logical]

So actually there won't be any error occur here but a condition short circuit will be missing if the first condition is false.

@HappyCat2
Copy link

HappyCat2 commented Sep 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants