Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Add total LP balances to the EARN dashboard #170

Open
superduck35 opened this issue Aug 25, 2020 · 6 comments
Open

Add total LP balances to the EARN dashboard #170

superduck35 opened this issue Aug 25, 2020 · 6 comments
Labels
challenge Part of the mStable tech challenge enhancement New feature or request

Comments

@superduck35
Copy link
Contributor

Is your feature request related to a problem? Please describe.

As an LP in EARN, I wish to see:

  1. the total amount of money I have in all EARN pools, quickly and easily
  2. the total amount of MTA I have earned and claimed since I started staking
  3. the USD amount and pool share amount (e.g. mUSD and MTA amounts) of each pool i'm staked in

Describe the solution you'd like

On the EARN page, I wish to see the total value of my LP tokens (BPT, UNI-V2) from all pools (1), with a breakdown of the amount of money I have in each pool. I also wish to see my % of the assets in the pool (see screenshot from Zapper.fi) e.g. 1500 mUSD && 20 MTA (2)

This could be added as an extra column(s) in the 'Your pools' section, or you could modify the 'Your pools' columns completely, or simply add some new data at the top of the EARN page.

image
image

I also wish to see a running counter, for all the MTA I have earned since I started staking, across all pools (3).

(3) Might be challenging. Have a go - and if it is too difficult to accumulate the results then let us know

Additional context

To get the total MTA earned per pool, you can simply add up all the 'claimed' events from the subgraph. You then add the total claimed, to the unclaimed rewards (see https://github.com/mstable/mStable-app/blob/master/src/components/pages/Earn/StakingRewardsContractProvider.tsx#L58)

Interested in working with mStable? Check out our dApp developer role

@superduck35 superduck35 added enhancement New feature or request challenge Part of the mStable tech challenge labels Aug 25, 2020
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 1.0 ETH (346.51 USD @ $342.25/ETH) has been submitted by:


@mul1sh
Copy link

mul1sh commented Oct 6, 2020

@alsco77 Is this bounty still open? I noticed it had expired in gitcoin, would like to work on it in the next 1 week if it's still open. Thanks.

@superduck35
Copy link
Contributor Author

Hey @mul1sh yes it's still open :) From what I can see there are currently no contributors.

@mul1sh
Copy link

mul1sh commented Oct 7, 2020

@alsco77 awesome thanks for the feedback, I've started working on it, will sent over a PR for you to test the above functionality in a bit :)

@hieple7985
Copy link

Hi @mul1sh, is this bounty still open?

@superduck35
Copy link
Contributor Author

Yes @hieple7985

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
challenge Part of the mStable tech challenge enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants